Skip to content

Added music extraction toggle to decompiler options - #1038

Open
Jakjm wants to merge 4 commits into
open-goal:mainfrom
Jakjm:main
Open

Jakjm wants to merge 4 commits into
open-goal:mainfrom
Jakjm:main

Conversation

@Jakjm

@Jakjm Jakjm commented Sep 19, 2026

Copy link
Copy Markdown

Following the merge of the music and sound effects extraction PR this PR adds a button to toggle on/off the rip_music decompiler flag for Jak 1 and 2. Because this is a new button, will definitely need to fix up the button text translations at some point. Obviously this button won't do anything until the launcher is using a tooling that contains the music/sfx extraction PR.

Another important note to keep in mind: the PR also changed the effects of rip_streamed_audio. In addition to everything it would extract before, it will now also extract sound effects. Perhaps we want to update the button text for the rip_streamed_audio button to reflect this?

@trippjoe

Copy link
Copy Markdown
Member

Looks good, my only feedback is to keep the translation string in en-US.json and remove the rest.

To pass the formatting checks:
yarn format - for the frontend.
cd src-tauri and then cargo fmt - for the backend.

@trippjoe trippjoe added enhancement New feature or request rust Pull requests that update Rust code javascript Pull requests that update Javascript code labels Sep 19, 2026
@Jakjm

Jakjm commented Sep 20, 2026

Copy link
Copy Markdown
Author

Awesome, thanks for the feedback- I have very limited experience in typescript but I've used rust a fair bit now. I'm surprised I didn't know cargo had a built in formatter. Very cool :)

@Jakjm

Jakjm commented Sep 20, 2026

Copy link
Copy Markdown
Author

Ah wait for some reason some of the other translation file changes didn't get reverted, I'll fix that

@Jakjm

Jakjm commented Sep 20, 2026

Copy link
Copy Markdown
Author

@trippjoe do you think I should make sure the button only comes up if the tooling supports music extraction or something? I guess it's not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request javascript Pull requests that update Javascript code rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants