Conversation
Member
|
Looks good, my only feedback is to keep the translation string in To pass the formatting checks: |
Author
|
Awesome, thanks for the feedback- I have very limited experience in typescript but I've used rust a fair bit now. I'm surprised I didn't know cargo had a built in formatter. Very cool :) |
Author
|
Ah wait for some reason some of the other translation file changes didn't get reverted, I'll fix that |
Author
|
@trippjoe do you think I should make sure the button only comes up if the tooling supports music extraction or something? I guess it's not a big deal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the merge of the music and sound effects extraction PR this PR adds a button to toggle on/off the rip_music decompiler flag for Jak 1 and 2. Because this is a new button, will definitely need to fix up the button text translations at some point. Obviously this button won't do anything until the launcher is using a tooling that contains the music/sfx extraction PR.
Another important note to keep in mind: the PR also changed the effects of rip_streamed_audio. In addition to everything it would extract before, it will now also extract sound effects. Perhaps we want to update the button text for the rip_streamed_audio button to reflect this?