loader: reject remote file URL hosts#8715
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
anderseknert
reviewed
Jun 2, 2026
Member
anderseknert
left a comment
anderseknert
left a comment
There was a problem hiding this comment.
TIL. Looks good to me, although I think the error message could probably be more helpful. Will leave it up for others to have a say as there could be some concerns about breaking someone's deployments I suppose.
| } | ||
|
|
||
| if url.Host != "" && url.Host != "localhost" { | ||
| return "", fmt.Errorf("file URL host must be empty or localhost: %v", path) |
Member
There was a problem hiding this comment.
I'd bet that 9 times out of 10, this is just someone who missed a / after file:// and not someone who tried to provide a hostname or even knew that was possible. Perhaps the error message should better help them along?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file://server/...was being treated like a local path because OPA dropped the file URL host and used onlyurl.PathThat can rewrite the user input into a different local file path, which is pretty sketchy
This change only accepts local file URLs:
file:///...file://localhost/...It rejects other file URL hosts and adds regression tests
Repro:
printf '{"x":1}\n' > data.jsonserver:opa eval --data "file://server$(pwd)/data.json" 'data.x'file URL host must be empty or localhost