perf: avoid allocations in object.get#8729
Open
anderseknert wants to merge 1 commit into
Open
Conversation
This change removes the 1-2 heap allocations previously made per call to the `object.get` built-in function. Also: - Slightly tweak `builtins.<Type>Operand` functions to have them pass the inlining threshold score of 80 — they would previously all score at 81! Signed-off-by: Anders Eknert <anders.eknert@apple.com>
srenatus
reviewed
Jun 3, 2026
| func builtinObjectGet(_ BuiltinContext, operands []*ast.Term, iter func(*ast.Term) error) error { | ||
| object, err := builtins.ObjectOperand(operands[0].Value, 1) | ||
| // silly micro optimization: initial ref to last item avoids | ||
| // later bounds checks as 1 and 0then known to be valid indices |
Contributor
There was a problem hiding this comment.
Suggested change
| // later bounds checks as 1 and 0then known to be valid indices | |
| // later bounds checks as 1 and 0 then known to be valid indices |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the 1-2 heap allocations previously made per call to the
object.getbuilt-in function.Also:
builtins.<Type>Operandfunctions to have them pass the inlining threshold score of 80 — they would previously all score at 81!