ast: report violations from multiple compiler stages - #9175
Open
sspaink wants to merge 1 commit into
Open
Conversation
Compilation stopped at the first stage that recorded an error, so a policy with several violations only ever surfaced one. Errors from checks that leave the modules intact are now recoverable, so later stages still run, and the collected errors are sorted by location. Fixes: open-policy-agent#5815 Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation stopped at the first stage that recorded an error, so a policy with several violations only ever surfaced one. Errors from checks that leave the modules intact can now be marked as recoverable, so later stages still run, and the collected errors are sorted by location.
The only errors that have been marked recoverable are from stages that are read only and won't have the cascading error issue @johanfylling pointed out.
import data.foo unusedCheckUnusedImports(new stage)import must not shadow import data.fooCheckDuplicateImportsrules must not shadow input|data (use a different rule name)CheckKeywordOverridesvariables must not shadow input|data (use a different variable name)CheckKeywordOverridesargs must not shadow input|data (use a different variable name)CheckKeywordOverridesunused argument x. (hint: use _ (wildcard variable) instead)RewriteLocalVarsassigned var x unusedRewriteLocalVarsdeclared var x unusedRewriteLocalVarsThe policy from the issue will now print out 3 errors:
Fixes: #5815