Add missing LMS macros. Correct typo. #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ashman-p wants to merge 10 commits into main from ash_missing_lms_parms

+65 −13

Contributor

ashman-p commented Oct 30, 2025

Fixes #2121

Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged. Also, make sure to update the list of algorithms in the continuous benchmarking files: .github/workflows/kem-bench.yml and sig-bench.yml)

ashman-p self-assigned this

ashman-p requested review from baentsch and dstebila as code owners

October 30, 2025 02:40

coveralls commented Oct 30, 2025 •

edited

Loading

coverage: 83.588% (+0.001%) from 83.587%
when pulling f56e897 on ash_missing_lms_parms
into 46e2719 on main.

baentsch mentioned this pull request

Many LMS variants disabled with -DOQS_ENABLE_SIG_STFL_LMS=ON #2121

Open

ashman-p marked this pull request as draft

October 30, 2025 14:50

ashman-p marked this pull request as ready for review

November 1, 2025 02:29

ashman-p commented

View reviewed changes

tests/test_cmdline.py Outdated Show resolved Hide resolved

tests/test_cmdline.py Outdated Show resolved Hide resolved

baentsch reviewed

View reviewed changes

tests/test_kat.py Outdated Show resolved Hide resolved

baentsch reviewed

View reviewed changes

tests/test_speed.py Show resolved Hide resolved

baentsch reviewed

View reviewed changes

tests/test_speed.py Show resolved Hide resolved

baentsch reviewed

View reviewed changes

tests/test_cmdline.py Show resolved Hide resolved

baentsch reviewed

View reviewed changes

Member

baentsch left a comment

Thanks for this update @ashman-p -- beyond the functional fixes, can I assume the goal of this PR also is to reduce testing runtime? Please see single comments.

Contributor Author

ashman-p commented Nov 3, 2025

Correct. After the fix to enable the additional variants CI experienced timeouts.

ashman-p requested review from cothan and xuganyu96

November 5, 2025 15:47

xuganyu96 reviewed

View reviewed changes

Contributor

xuganyu96 left a comment

Made a few cosmetic suggestions. Will approve once I finish running the test suites myself.

src/oqsconfig.h.cmake Show resolved Hide resolved

tests/test_cmdline.py Outdated Show resolved Hide resolved

tests/test_kat.py Outdated Show resolved Hide resolved

tests/test_cmdline.py Outdated Show resolved Hide resolved

tests/test_speed.py Show resolved Hide resolved

Contributor Author

ashman-p commented Nov 6, 2025

Made a few cosmetic suggestions. Will approve once I finish running the test suites myself.

Thanks for reviewing.

ashman-p closed this

ashman-p reopened this

ashman-p added 10 commits

November 5, 2025 20:46


          Add missing LMS macros. Correct typo.

e01b43f

Signed-off-by: Norman Ashley <[email protected]>


          Fix format so that the correct hash can be calculated.

32bd837

Signed-off-by: Norman Ashley <[email protected]>


          Skip slow running LMS tests.

999ae30

Signed-off-by: Norman Ashley <[email protected]>


          Update KAT hash result. Skip tests if no test file present.

6a7f4cf

Signed-off-by: Norman Ashley <[email protected]>


          Restrict really slow testcases.

Signed-off-by: Norman Ashley <[email protected]>


          Restrict slow LMS variants.

14d5042

Signed-off-by: Norman Ashley <[email protected]>


          Update tests/test_cmdline.py

c7d39cf

Signed-off-by: Norman Ashley <[email protected]>


          Update tests/test_cmdline.py

2aa3117

Signed-off-by: Norman Ashley <[email protected]>


          Updates per review.

dbacc39

Signed-off-by: Norman Ashley <[email protected]>


          Update per review: use pytest.xfail.

60bd9ac

Signed-off-by: Norman Ashley <[email protected]>

ashman-p force-pushed the ash_missing_lms_parms branch from 3c3ba64 to 60bd9ac Compare

November 6, 2025 01:46

cothan approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet