Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update UI component for improved design #249

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

Codexnever
Copy link
Contributor

@Codexnever Codexnever commented Oct 12, 2024

Description

This PR updates the UI of the card component to improve layout and responsiveness. Additionally, the button within the card is positioned at the bottom for better usability and visual appeal. Please note that the deploy preview link is currently not working, but the changes have been tested locally and are functioning as expected.

Related Tickets & Documents

Closes #243

Mobile & Desktop Screenshots/Recordings

Before
Before

After
After

Steps to QA

  1. Pull the latest changes.
  2. Run the project locally.
  3. Verify that the card layout is responsive and the button is correctly positioned at the bottom.
  4. Ensure no issues arise with other components.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@Codexnever Codexnever requested a review from a team as a code owner October 12, 2024 21:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for learn-opensauced ready!

Name Link
🔨 Latest commit 83d11ca
🔍 Latest deploy log https://app.netlify.com/sites/learn-opensauced/deploys/671a8dd80f44bb00092623dc
😎 Deploy Preview https://deploy-preview-249--learn-opensauced.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Codexnever Codexnever changed the title Fix : Update UI component for improved design Fix: Update UI component for improved design Oct 12, 2024
@Codexnever Codexnever changed the title Fix: Update UI component for improved design fix: Update UI component for improved design Oct 12, 2024
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Codexnever, please don't delete sections in the PR template.

You must complete the template, and when a section is not related to your PR, you can leave it blank.

Have you read all the comments in the PR template?
One of it says:

<!-- note: PRs with deleted sections will be marked invalid -->

That being said, please fix your PR template before we review your PR. Alternatively, you can close this PR and create a new one.

Thank you. 🙂

@Codexnever
Copy link
Contributor Author

Hi @Codexnever, please don't delete sections in the PR template.

You must complete the template, and when a section is not related to your PR, you can leave it blank.

Have you read all the comments in the PR template? One of it says:

<!-- note: PRs with deleted sections will be marked invalid -->

That being said, please fix your PR template before we review your PR. Alternatively, you can close this PR and create a new one.

Thank you. 🙂

Hi @adiati98,

Thank you for your feedback! I apologize for the oversight and for deleting sections of the PR template. I will update the PR template to ensure that all sections are retained and follow the guidelines correctly

Thanks again for your understanding! 🙂

@adiati98
Copy link
Member

adiati98 commented Oct 13, 2024

Do let me know once you've fixed it, @Codexnever. 👍🏼
You can take a look at closed PRs to see what you've removed.

@adiati98
Copy link
Member

@Codexnever your PR should look like this.

Screenshot 2024-10-14 165353

@Codexnever
Copy link
Contributor Author

@Codexnever your PR should look like this.

Screenshot 2024-10-14 165353

Hey @adiati98 ,

Sorry for submitting the wrong template earlier. Now i corrected you can check

Thanks for understanding!

Best,
Chaitanya

package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @Codexnever! ✨

thank you gif

@adiati98 adiati98 requested a review from BekahHW October 24, 2024 18:40
package-lock.json Outdated Show resolved Hide resolved
@BekahHW BekahHW merged commit 42c8e2d into open-sauced:main Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Misaligned Buttons in Course Cards on the Homepage Due to Varying Content Length
3 participants