-
Notifications
You must be signed in to change notification settings - Fork 79
Update CONTRIBUTING.md #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update CONTRIBUTING.md #1425
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
+ Coverage 63.65% 63.76% +0.10%
==========================================
Files 159 159
Lines 3134 3146 +12
Branches 326 325 -1
==========================================
+ Hits 1995 2006 +11
- Misses 1042 1043 +1
Partials 97 97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gregory-at-cvs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good updates @breedx-splk 👍.
I left a heads up about a misspelled word and a question. Let me know after you've added a response or change and I'll schedule in time to review.
|
Thanks for the review, @gregory-at-cvs. 👍🏻 |
You're welcome @breedx-splk. |
fractalwrench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds some additional guidance about assertions, mocking, and the PR process.