Skip to content

Commit

Permalink
fix presubmits
Browse files Browse the repository at this point in the history
  • Loading branch information
dashpole committed Feb 11, 2025
1 parent 1bd6882 commit 769ca83
Show file tree
Hide file tree
Showing 4 changed files with 175 additions and 2 deletions.
27 changes: 27 additions & 0 deletions .chloggen/metricstarttime-true-reset.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: metricstarttimeprocessor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: add true_reset_point strategy for setting the start timestamp of cumulative points.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [37186]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: The implementation is copied from the Prometheus receiver.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user, api]
2 changes: 1 addition & 1 deletion processor/metricstarttimeprocessor/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Pros:

Cons:

* This strategy is **stateful** because the initial True Reset point is neccessary to properly calculate rates on subsequent points.
* This strategy is **stateful** because the initial True Reset point is necessary to properly calculate rates on subsequent points.
* The True Reset point doesn't make sense semantically. It has a zero duration, but non-zero values.
* Many backends reject points with equal start and end timestamps.
* If the True Reset point is rejected, the next point will appear to have a very large rate.
4 changes: 3 additions & 1 deletion processor/metricstarttimeprocessor/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/processor/metri
go 1.22.0

require (
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil v0.119.1-0.20250210123122-44b3eeda354c
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil v0.119.0
github.com/stretchr/testify v1.10.0
go.opentelemetry.io/collector/component v0.119.1-0.20250210123122-44b3eeda354c
go.opentelemetry.io/collector/component/componenttest v0.119.1-0.20250210123122-44b3eeda354c
Expand Down Expand Up @@ -56,3 +56,5 @@ require (
google.golang.org/protobuf v1.36.5 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)

replace github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil => ../../pkg/pdatautil
144 changes: 144 additions & 0 deletions processor/metricstarttimeprocessor/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 769ca83

Please sign in to comment.