Addressing PR comments

Signed-off-by: Samiur Arif <[email protected]>
open-telemetry · Feb 4, 2025 · a21d98a · a21d98a
1 parent d246ffd
commit a21d98a
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/.chloggen/add-more-vecenter-receiver-virtual-machine-preformace-metrics.yaml b/.chloggen/add-more-vecenter-receiver-virtual-machine-preformace-metrics.yaml
@@ -7,7 +7,7 @@ change_type: enhancement
 component: vcenterreceiver
 
 # A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
-note: Adds six more Vcenter virtual machine performance metrics
+note: Adds three more vCenter virtual machine performance metrics
 
 # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
 issues: [37488]

diff --git a/receiver/vcenterreceiver/documentation.md b/receiver/vcenterreceiver/documentation.md
@@ -822,7 +822,7 @@ Total memory  capacity of the host system.
 
 ### vcenter.vm.cpu.time
 
-CPU time spent in idle, ready or idle state.
+CPU time spent in idle, ready or wait state.
 
 As measured over the most recent 20s interval.
 

diff --git a/receiver/vcenterreceiver/internal/metadata/generated_metrics.go b/receiver/vcenterreceiver/internal/metadata/generated_metrics.go
diff --git a/receiver/vcenterreceiver/internal/metadata/generated_metrics_test.go b/receiver/vcenterreceiver/internal/metadata/generated_metrics_test.go
diff --git a/receiver/vcenterreceiver/metadata.yaml b/receiver/vcenterreceiver/metadata.yaml
@@ -107,7 +107,7 @@ attributes:
       - "standby"
       - "unknown"
   cpu_state: 
-    description: CPU time spent in idle, ready or idle state.  
+    description: CPU time spent in idle, ready or idle state.
     type: string
     enum:
       - "idle"
@@ -577,7 +577,7 @@ metrics:
     attributes: []
   vcenter.vm.cpu.time:
     enabled: false
-    description:  CPU time spent in idle, ready or idle state.
+    description:  CPU time spent in idle, ready or wait state.
     unit: "%"
     gauge:
       value_type: double 

diff --git a/receiver/vcenterreceiver/testdata/metrics/expected-all-enabled.yaml b/receiver/vcenterreceiver/testdata/metrics/expected-all-enabled.yaml
@@ -2167,7 +2167,7 @@ resourceMetrics:
                   timeUnixNano: "2000000"
             name: vcenter.vm.cpu.readiness
             unit: '%'
-          - description: CPU time spent in idle, ready or idle state.
+          - description: CPU time spent in idle, ready or wait state.
             gauge:
               dataPoints:
                 - asDouble: "1.0"
@@ -2998,7 +2998,7 @@ resourceMetrics:
                   timeUnixNano: "2000000"
             name: vcenter.vm.cpu.readiness
             unit: '%'
-          - description: CPU time spent in idle, ready or idle state. 
+          - description: CPU time spent in idle, ready or wait state. 
             gauge:
               dataPoints:
                 - asDouble: "1.0"
@@ -3928,7 +3928,7 @@ resourceMetrics:
                   timeUnixNano: "2000000"
             name: vcenter.vm.cpu.readiness
             unit: '%'
-          - description: CPU time spent in idle, ready or idle state. 
+          - description: CPU time spent in idle, ready or wait state. 
             gauge:
               dataPoints:
                 - asDouble: "1.0"