-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Use crosslink tidylist in make gotidy (attempt 2)
#37418
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f5e0bae
Use `crosslink tidylist` in `make gotidy`
jade-guiton-dd 3d8dc1b
Merge branch 'main' into use-tidylist-v2
jade-guiton-dd aca1868
make tidylist
jade-guiton-dd 5d6b9fb
Merge branch 'main' into use-tidylist-v2
mx-psi 37540a4
make tidylist
jade-guiton-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # This file lists modules that are known to have intra-repository circular dependencies. | ||
| # The `make tidylist` command will check against this list and error out if circular dependencies | ||
| # are accidentally added or removed. | ||
|
|
||
| # exporter/datadog <-> connector/datadog | ||
| exporter/datadogexporter | ||
| connector/datadogconnector | ||
|
|
||
| # receiver/otelarrow <-> internal/otelarrow <-> exporter/otelarrow | ||
| receiver/otelarrowreceiver | ||
| exporter/otelarrowexporter | ||
| internal/otelarrow | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,299 @@ | ||
| cmd/githubgen | ||
| cmd/opampsupervisor | ||
| cmd/telemetrygen | ||
| internal/common | ||
| cmd/telemetrygen/internal/e2etest | ||
| confmap/provider/aesprovider | ||
| confmap/provider/s3provider | ||
| confmap/provider/secretsmanagerprovider | ||
| pkg/pdatautil | ||
| pkg/golden | ||
| pkg/pdatatest | ||
| internal/coreinternal | ||
| pkg/ottl | ||
| internal/filter | ||
| connector/countconnector | ||
| internal/aws/ecsutil | ||
| internal/k8sconfig | ||
| internal/metadataproviders | ||
| pkg/resourcetotelemetry | ||
| internal/k8stest | ||
| processor/k8sattributesprocessor | ||
| pkg/sampling | ||
| processor/probabilisticsamplerprocessor | ||
| processor/resourcedetectionprocessor | ||
| internal/pdatautil | ||
| processor/transformprocessor | ||
| internal/docker | ||
| receiver/dockerstatsreceiver | ||
| extension/storage | ||
| pkg/stanza | ||
| receiver/filelogreceiver | ||
| pkg/experimentalmetricmetadata | ||
| receiver/hostmetricsreceiver | ||
| pkg/translator/prometheus | ||
| pkg/translator/prometheusremotewrite | ||
| exporter/prometheusremotewriteexporter | ||
| receiver/prometheusreceiver | ||
| pkg/datadog | ||
| processor/tailsamplingprocessor | ||
| exporter/datadogexporter | ||
| connector/datadogconnector | ||
| exporter/datadogexporter | ||
| connector/exceptionsconnector | ||
| connector/failoverconnector | ||
| connector/grafanacloudconnector | ||
| connector/otlpjsonconnector | ||
| connector/roundrobinconnector | ||
| connector/routingconnector | ||
| connector/servicegraphconnector | ||
| connector/signaltometricsconnector | ||
| connector/spanmetricsconnector | ||
| connector/sumconnector | ||
| examples/demo/client | ||
| examples/demo/server | ||
| exporter/alertmanagerexporter | ||
| exporter/alibabacloudlogserviceexporter | ||
| internal/aws/awsutil | ||
| internal/aws/cwlogs | ||
| exporter/awscloudwatchlogsexporter | ||
| internal/aws/metrics | ||
| exporter/awsemfexporter | ||
| pkg/translator/jaeger | ||
| pkg/translator/zipkin | ||
| exporter/awskinesisexporter | ||
| exporter/awss3exporter | ||
| internal/aws/xray | ||
| exporter/awsxrayexporter | ||
| exporter/azuredataexplorerexporter | ||
| exporter/azuremonitorexporter | ||
| exporter/bmchelixexporter | ||
| exporter/carbonexporter | ||
| exporter/cassandraexporter | ||
| exporter/clickhouseexporter | ||
| exporter/coralogixexporter | ||
| exporter/datadogexporter/integrationtest | ||
| exporter/datasetexporter | ||
| exporter/dorisexporter | ||
| exporter/elasticsearchexporter | ||
| extension/storage/filestorage | ||
| internal/sharedcomponent | ||
| pkg/translator/opencensus | ||
| receiver/opencensusreceiver | ||
| exporter/opencensusexporter | ||
| exporter/prometheusexporter | ||
| internal/splunk | ||
| pkg/batchperresourceattr | ||
| exporter/sapmexporter | ||
| pkg/translator/signalfx | ||
| exporter/signalfxexporter | ||
| exporter/syslogexporter | ||
| receiver/zipkinreceiver | ||
| exporter/zipkinexporter | ||
| receiver/carbonreceiver | ||
| internal/exp/metrics | ||
| receiver/datadogreceiver | ||
| receiver/jaegerreceiver | ||
| receiver/sapmreceiver | ||
| receiver/signalfxreceiver | ||
| exporter/splunkhecexporter | ||
| extension/ackextension | ||
| receiver/splunkhecreceiver | ||
| receiver/syslogreceiver | ||
| testbed/mockdatasenders/mockdatadogagentexporter | ||
| testbed | ||
| exporter/elasticsearchexporter/integrationtest | ||
| extension/encoding | ||
| extension/encoding/otlpencodingextension | ||
| exporter/fileexporter | ||
| exporter/googlecloudexporter | ||
| exporter/googlecloudpubsubexporter | ||
| exporter/googlemanagedprometheusexporter | ||
| exporter/honeycombmarkerexporter | ||
| exporter/influxdbexporter | ||
| internal/kafka | ||
| pkg/batchpersignal | ||
| pkg/kafka/topic | ||
| exporter/kafkaexporter | ||
| exporter/kineticaexporter | ||
| exporter/loadbalancingexporter | ||
| exporter/logicmonitorexporter | ||
| exporter/logzioexporter | ||
| pkg/translator/loki | ||
| exporter/lokiexporter | ||
| exporter/mezmoexporter | ||
| exporter/opensearchexporter | ||
| internal/grpcutil | ||
| receiver/otelarrowreceiver | ||
| internal/otelarrow | ||
| exporter/otelarrowexporter | ||
| receiver/otelarrowreceiver | ||
| internal/otelarrow | ||
| exporter/otelarrowexporter | ||
| receiver/otelarrowreceiver | ||
| exporter/pulsarexporter | ||
| internal/rabbitmq | ||
| exporter/rabbitmqexporter | ||
| exporter/sentryexporter | ||
| extension/sumologicextension | ||
| exporter/sumologicexporter | ||
| exporter/tencentcloudlogserviceexporter | ||
| extension/asapauthextension | ||
| internal/aws/proxy | ||
| extension/awsproxy | ||
| extension/basicauthextension | ||
| extension/bearertokenauthextension | ||
| extension/cgroupruntimeextension | ||
| extension/encoding/avrologencodingextension | ||
| extension/encoding/jaegerencodingextension | ||
| extension/encoding/jsonlogencodingextension | ||
| pkg/translator/skywalking | ||
| extension/encoding/skywalkingencodingextension | ||
| extension/encoding/textencodingextension | ||
| extension/encoding/zipkinencodingextension | ||
| extension/googleclientauthextension | ||
| extension/headerssetterextension | ||
| extension/healthcheckextension | ||
| pkg/status | ||
| extension/healthcheckv2extension | ||
| extension/httpforwarderextension | ||
| extension/jaegerremotesampling | ||
| extension/oauth2clientauthextension | ||
| extension/observer | ||
| extension/observer/cfgardenobserver | ||
| extension/observer/dockerobserver | ||
| extension/observer/ecsobserver | ||
| extension/observer/ecstaskobserver | ||
| extension/observer/hostobserver | ||
| extension/observer/k8sobserver | ||
| extension/oidcauthextension | ||
| extension/opampcustommessages | ||
| extension/opampextension | ||
| extension/pprofextension | ||
| extension/remotetapextension | ||
| extension/sigv4authextension | ||
| extension/solarwindsapmsettingsextension | ||
| extension/storage/dbstorage | ||
| extension/storage/redisstorageextension | ||
| . | ||
| internal/aws/containerinsight | ||
| internal/aws/k8s | ||
| internal/aws/xray/testdata/sampleapp | ||
| internal/aws/xray/testdata/sampleserver | ||
| internal/collectd | ||
| internal/kubelet | ||
| internal/sqlquery | ||
| internal/tools | ||
| pkg/translator/azure | ||
| pkg/translator/azurelogs | ||
| pkg/winperfcounters | ||
| processor/attributesprocessor | ||
| processor/coralogixprocessor | ||
| processor/cumulativetodeltaprocessor | ||
| processor/deltatocumulativeprocessor | ||
| processor/deltatorateprocessor | ||
| processor/filterprocessor | ||
| processor/geoipprocessor | ||
| processor/groupbyattrsprocessor | ||
| processor/groupbytraceprocessor | ||
| processor/intervalprocessor | ||
| processor/logdedupprocessor | ||
| processor/logstransformprocessor | ||
| processor/metricsgenerationprocessor | ||
| processor/metricstransformprocessor | ||
| processor/redactionprocessor | ||
| processor/remotetapprocessor | ||
| processor/resourceprocessor | ||
| processor/routingprocessor | ||
| processor/schemaprocessor | ||
| processor/spanprocessor | ||
| processor/sumologicprocessor | ||
| receiver/activedirectorydsreceiver | ||
| receiver/aerospikereceiver | ||
| receiver/apachereceiver | ||
| receiver/apachesparkreceiver | ||
| receiver/awscloudwatchmetricsreceiver | ||
| receiver/awscloudwatchreceiver | ||
| receiver/awscontainerinsightreceiver | ||
| receiver/awsecscontainermetricsreceiver | ||
| receiver/awsfirehosereceiver | ||
| receiver/awss3receiver | ||
| receiver/awsxrayreceiver | ||
| receiver/azureblobreceiver | ||
| receiver/azureeventhubreceiver | ||
| receiver/azuremonitorreceiver | ||
| receiver/bigipreceiver | ||
| receiver/chronyreceiver | ||
| receiver/cloudflarereceiver | ||
| receiver/cloudfoundryreceiver | ||
| receiver/collectdreceiver | ||
| receiver/couchdbreceiver | ||
| receiver/elasticsearchreceiver | ||
| receiver/expvarreceiver | ||
| receiver/filestatsreceiver | ||
| receiver/flinkmetricsreceiver | ||
| receiver/fluentforwardreceiver | ||
| receiver/githubreceiver | ||
| receiver/gitlabreceiver | ||
| receiver/googlecloudmonitoringreceiver | ||
| receiver/googlecloudpubsubreceiver | ||
| receiver/googlecloudspannerreceiver | ||
| receiver/haproxyreceiver | ||
| receiver/httpcheckreceiver | ||
| receiver/huaweicloudcesreceiver | ||
| receiver/iisreceiver | ||
| receiver/influxdbreceiver | ||
| receiver/jmxreceiver | ||
| receiver/journaldreceiver | ||
| receiver/k8sclusterreceiver | ||
| receiver/k8seventsreceiver | ||
| receiver/k8sobjectsreceiver | ||
| receiver/kafkametricsreceiver | ||
| receiver/kafkareceiver | ||
| receiver/kubeletstatsreceiver | ||
| receiver/libhoneyreceiver | ||
| receiver/lokireceiver | ||
| receiver/memcachedreceiver | ||
| receiver/mongodbatlasreceiver | ||
| receiver/mongodbreceiver | ||
| receiver/mysqlreceiver | ||
| receiver/namedpipereceiver | ||
| receiver/netflowreceiver | ||
| receiver/nginxreceiver | ||
| receiver/nsxtreceiver | ||
| receiver/ntpreceiver | ||
| receiver/oracledbreceiver | ||
| receiver/osqueryreceiver | ||
| receiver/otlpjsonfilereceiver | ||
| receiver/podmanreceiver | ||
| receiver/postgresqlreceiver | ||
| receiver/prometheusremotewritereceiver | ||
| receiver/pulsarreceiver | ||
| receiver/purefareceiver | ||
| receiver/purefbreceiver | ||
| receiver/rabbitmqreceiver | ||
| receiver/receivercreator | ||
| receiver/redisreceiver | ||
| receiver/riakreceiver | ||
| receiver/saphanareceiver | ||
| receiver/simpleprometheusreceiver/examples/federation/prom-counter | ||
| receiver/simpleprometheusreceiver | ||
| receiver/skywalkingreceiver | ||
| receiver/snmpreceiver | ||
| receiver/snowflakereceiver | ||
| receiver/solacereceiver | ||
| receiver/splunkenterprisereceiver | ||
| receiver/sqlqueryreceiver | ||
| receiver/sqlserverreceiver | ||
| receiver/sshcheckreceiver | ||
| receiver/statsdreceiver | ||
| receiver/systemdreceiver | ||
| receiver/tcplogreceiver | ||
| receiver/tlscheckreceiver | ||
| receiver/udplogreceiver | ||
| receiver/vcenterreceiver | ||
| receiver/wavefrontreceiver | ||
| receiver/webhookeventreceiver | ||
| receiver/windowseventlogreceiver | ||
| receiver/windowsperfcountersreceiver | ||
| receiver/zookeeperreceiver |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not strictly necessary to move these, but maybe they would be better suited under
internal/buildscriptsor in the .github directory?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since those files aren't scripts and aren't used as part of building the Collector, and they're used as part of local development rather than CI, those directories didn't feel appropriate, but maybe I can move it into
buildscriptsif we relax the definition a bit?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codeboten What do you think would be the best location for these files?