Olivierg/gateway usage gauge #37499
Open
Olivierg/gateway usage gauge #37499
+200
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr,
mx-psi and
songy23
songy23
reviewed
Jan 27, 2025
| github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/attributes v0.24.0 | ||
| github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/logs v0.24.0 | ||
| github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/metrics v0.24.0 | ||
| github.com/DataDog/opentelemetry-mapping-go/pkg/inframetadata v0.24.1-0.20250124131402-bcd6fd1617a6 |
There was a problem hiding this comment.
Please make a new release of mapping-go after your other PR is merged
songy23
reviewed
Jan 27, 2025
| @@ -67,6 +69,17 @@ func DefaultMetrics(exporterType string, hostname string, timestamp uint64, tags | |||
| return metrics | |||
| } | |||
|
|
|||
| // GatewayUsageGauge creates a gauge metric to report is there is a gateway | |||
| func GatewayUsageGauge(timestamp uint64, hostname string, tags []string, gatewayUsage *attributes.GatewayUsage) datadogV2.MetricSeries { | |||
| series := NewGauge("datadog.otel.gateway", timestamp, gatewayUsage.Gauge(), tags) | |||
There was a problem hiding this comment.
What if the gateway host is from traces, metrics and logs, does this gauge report value of 3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new gauge metric
datadog.otel.gateway. This metric is set at1when the collector is used as a gateway otherwise, the value is0.If
datadog.host.namewas sent with two different values, then the collector is used as a gateway.Note: The PR on opentelemetry-mapping-go should be merged before this PR and
go.modmust use a commit on main instead of0.24.1-0.20250124131402-bcd6fd1617a6Associated PRs:
Link to tracking issue
Fixes
Testing
The following commands generates the metric
datadog.otel.gatewayat1Same tests were performed for
tracesand forlogswhenisLogsAgentExporterEnabledis false.Documentation