36330 bi as attrs #37508
Open
36330 bi as attrs #37508
+905
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalper2
force-pushed
the
36330-bi-as-attrs
branch
from
eaf8c05 to
7293a9a
Compare
| case string: | ||
| endpointType = t | ||
| default: | ||
| endpointType = fmt.Sprintf("%v", eptType) |
There was a problem hiding this comment.
You can call fmt.Sprint here instead of providing the formatter
shalper2
force-pushed
the
36330-bi-as-attrs
branch
from
1ec48fd to
9b45c45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new attribute which optionally includes build and/or version info for the Splunk host being monitored. Also removed the use of
contextmodule in the client calls used by the scrape functions.Link to tracking issue
Fixes 36330
Testing
unit tests updated and passing
Documentation
README.md was updated to include new configuration field