Update module github.com/ReneKroon/ttlcache/v2 to v3 #37524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
dependencies
dashpole
force-pushed
the
update_ttlcache
branch
from
2c0a0b9 to
849c73b
Compare
dashpole
force-pushed
the
update_ttlcache
branch
from
addf44b to
26dea3f
Compare
|
cc @codeboten |
andrzej-stencel
approved these changes
Jan 29, 2025
|
cc @dsimil @KiranmayiB @harishbohara11 Would appreciate a review from one of you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #36209
Most of the changes are obvious renames or refactors. The non-obvious changes are:
Start()must now be called on the cache to enable cleanup in the background.Stop()can only be called once (or it will block indefinitely). I've added a sync.Once to ensure it is only ever called once.Set()andGet()no longer return errors--even if Stop has already been called. This makes some of our tests obsolete, and I removed those tests.Link to tracking issue
Fixes #36112