[receiver/tcpcheck] Add New Receiver#34458 #37556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@yanfeng1992 To add you as a code owner for running pipeline checks, could you create a new PR for membership? Thanks! Here’s an example: link |
chengchuanpeng
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
dmitryax,
jpkrohling,
evan-bradley,
TylerHelmuth,
ChrsMark,
yurishkuro,
mwear,
codeboten,
mx-psi,
bogdandrutu,
songy23,
tigrannajaryan and
jsuereth
as code owners
chengchuanpeng
force-pushed
the
tcpcheck-receiver
branch
2 times, most recently
from
d37e646 to
dd615eb
Compare
songy23
removed request for
fatsheep9146,
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
dmitryax,
jpkrohling,
evan-bradley,
TylerHelmuth,
ChrsMark,
mwear,
codeboten,
mx-psi,
bogdandrutu,
songy23,
tigrannajaryan,
jsuereth and
Erog38
chengchuanpeng
force-pushed
the
tcpcheck-receiver
branch
2 times, most recently
from
c5b5ae7 to
1c40246
Compare
|
Hi @yanfeng1992, If you become an otel member, we’d be happy to add you back, or You can also create a new PR if needed. Let me know if you have any questions! Thanks for your understanding! |
[receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Change CODEOWNERS#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Fix Version And Test#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Temporarily Change Owner#34458 [receiver/tcpcheck] Change Version#34458 [receiver/tcpcheck] Make Fmt#34458 [receiver/tcpcheck] Rebase#34458 [receiver/tcpcheck] Fix Test#34458 [receiver/tcpcheck] Make Tidy#34458
chengchuanpeng
force-pushed
the
tcpcheck-receiver
branch
from
f157be2 to
17d64d9
Compare
|
Hi @atoulme, I hope you're doing well! I would love your feedback whenever you have time. Let me know if I can improve anything to make this easier to review :) . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huangyanfeng [email protected], chengchuanpeng [email protected],
This PR builds upon the work from @yanfeng1992. We really appreciate the effort and thought he put into the original implementation, which laid the groundwork for this update. While there were some changes needed, his contribution was instrumental in guiding the direction of this PR
Description:
To monitor the availability and performance of TCP endpoints.
Use case: TCP network detection plug-in, usually used to monitor whether a TCP port on the local machine is listening, or whether a remote port can be connected
Link to tracking Issue:
#34414
Testing:
(1) PR Includes coverage ~85% in the package with the scraper.
(2) Also includes coverage ~80% in the internal/configtcp package
Documentation:
The new receiver includes documentation in receiver/tcpcheckreceiver/README.md and receiver/tcpcheckreceiver/documentation.md.