[extension/jaegerremotesampling] Add validation to detect port conflicts #46010
+305
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced Validate() method to check for port conflicts between HTTP and gRPC servers - Added extractPort() helper function to parse endpoint strings - Added comprehensive unit tests for validation logic - Validation fails fast with clear, actionable error messages Fixes open-telemetry#45944
|
|
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
Author
|
Additional context: The validation logic was intentionally placed inside Validate() to ensure misconfigurations are caught during startup configuration parsing rather than during server initialization. This approach aligns with existing validation patterns in other extensions. |
yurishkuro
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[extension/jaegerremotesampling] Add validation to detect port conflicts
The jaegerremotesampling extension previously allowed HTTP and gRPC servers to be configured on the same port, which could lead to runtime port binding failures.
This change enhances the Validate() method to proactively detect port conflicts during configuration loading and fail fast with a clear, actionable error message.
Changes introduced:
All tests pass and golangci-lint reports no issues.
Fixes #45944