[chore][receiver/prometheusremotewrite] - Refactor TestRemoteWriteHistogramWithExemplars #46020
+269
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
requested review from
a team,
ArthurSens and
dashpole
as code owners
There was a problem hiding this comment.
Pull request overview
Refactors the Prometheus remote-write receiver unit tests by folding the former TestRemoteWriteHistogramWithExemplars cases into the existing table-driven TestTranslateV2 suite, keeping histogram+exemplar translation coverage consolidated in one place.
Changes:
- Moved histogram-with-exemplars and multi-histogram-with-exemplars scenarios into
TestTranslateV2as additional table cases. - Updated expected OTLP metrics for those cases to include Prometheus metric-type metadata (
prometheus.MetricMetadataTypeKey="histogram") and expectedWriteResponseStats. - Reordered test helpers (
mockConsumer, etc.) and adjusted assertions inTestTargetInfoWithMultipleRequests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
perebaj
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
TestRemoteWriteHistogramWithExemplarsintoTestTranslateV2.