Skip to content

[chore] bump otel go dep #13078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented May 22, 2025

Fixes #12701

Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (58e643b) to head (8417183).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13078   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         505      505           
  Lines       28475    28475           
=======================================
  Hits        26078    26078           
  Misses       1883     1883           
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten marked this pull request as ready for review May 23, 2025 14:29
@codeboten codeboten requested a review from a team as a code owner May 23, 2025 14:29
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten enabled auto-merge May 23, 2025 14:34
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but I think it is breaking the contrib tests?

github.com/prometheus/client_model v0.6.2 // indirect
github.com/prometheus/common v0.62.0 // indirect
github.com/prometheus/procfs v0.15.1 // indirect
github.com/prometheus/common v0.64.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this leads to problems - this is blocked by open-telemetry/opentelemetry-collector-contrib#39729

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah..... interestingly enough i'm not able to repro this failure locally

@codeboten
Copy link
Contributor Author

Closing this as it will be addressed w/ #13098

@codeboten codeboten closed this May 28, 2025
auto-merge was automatically disabled May 28, 2025 15:41

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service/telemetry/metrics] GRPC OTLP periodic reader ignores insecure configuration
3 participants