Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on runtime.Start for scheduling metrics #6686

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

anuraaga
Copy link
Contributor

Had completely missed scheduling metrics are separate from what otherwise seems like the full entrypoint to the package. I think a link to the other entrypoint would be very helpful here.

@anuraaga anuraaga requested review from dmathieu, dashpole and a team as code owners January 27, 2025 04:09
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 27, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1%. Comparing base (e49abb5) to head (7da9bf4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6686     +/-   ##
=======================================
- Coverage   73.1%   73.1%   -0.1%     
=======================================
  Files        191     191             
  Lines      15858   15858             
=======================================
- Hits       11604   11598      -6     
- Misses      3921    3925      +4     
- Partials     333     335      +2     
Files with missing lines Coverage Δ
instrumentation/runtime/runtime.go 76.2% <ø> (ø)

... and 1 file with indirect coverage changes

@dmathieu dmathieu merged commit 6eaddb9 into open-telemetry:main Jan 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants