jmx-scraper wildfly metrics doc link to instrumentation #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsunday
approved these changes
Aug 18, 2025
|
@SylvainJuge #2129 is merged, ok to mark this ready to review and merge now? thanks |
Yes please, I've just marked it as ready for review. |
trask
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When dependency to instrumentation will be updated to 2.19.0 (currently 2.18.1), the metrics collected for wildfly will be inherited from instrumentation.
This PR just adds a link to the upstream documentation/definitions in instrumentation repository.
bonus: add missing link for tomcat docs
PR opened as draft as instrumentation 2.19.0 is not released yet, should be merged once release has been published and dependency in contrib repo updated.