Skip to content

Conversation

@mcmho
Copy link
Contributor

@mcmho mcmho commented Oct 17, 2025

Description:
Feature / Improvement: use weaver model to describe metrics so that they can be standardized.

  • created metrics.yaml weaver model for jvm metrics
  • created attriutes.yaml
  • tested with weaver registry generate

Testing:

  • tested with weaver registry generate; metadata.yaml is successfully generated and content is valided

Documentation:

  • customer facing docs not yet needed

Outstanding items:

  • once this looks good, there will be other models to work on for other target systems.

…try#2072

 - created metrics.yaml weaver model
 - created attriutes.yaml
 - tested with weaver registry generate
@mcmho mcmho requested a review from a team as a code owner October 17, 2025 00:15
mcmho added 2 commits October 22, 2025 17:07
…try#2072

 - tested weaver model locally as well as on docker
 - completed Makefile
…try#2072

 - tested weaver model locally as well as on docker
 - completed Makefile
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please look at the CI?

@SylvainJuge
Copy link
Contributor

I am not familiar with weaver, does it means that the jmx scraper yaml configuration would be now generated from registry+template ? Maybe we could modify the yaml format to make this easier or even avoid having to use a template.

Do you have an high level overview of what this change helps to achieve?

Also, the metrics descriptions are part of what is being tested in unit tests, so when changing them you'll have to update the test code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants