Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert vertx-rx-java-3.5 tests to java #13117

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Convert vertx-rx-java-3.5 tests to java #13117

merged 2 commits into from
Jan 28, 2025

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jan 28, 2025

Last part of #7195

@laurit laurit requested a review from a team as a code owner January 28, 2025 12:12
jaydeluca
jaydeluca reviewed Jan 28, 2025
View reviewed changes
...etry/javaagent/instrumentation/vertx/reactive/client/VertxRxCircuitBreakerWebClientTest.java Outdated Show resolved Hide resolved
...a/io/opentelemetry/javaagent/instrumentation/vertx/reactive/client/VertxRxWebClientTest.java Outdated Show resolved Hide resolved
...o/opentelemetry/javaagent/instrumentation/vertx/reactive/server/AbstractVertxRxVerticle.java Show resolved Hide resolved
...io/opentelemetry/javaagent/instrumentation/vertx/reactive/server/VertxReactiveWebServer.java Outdated Show resolved Hide resolved
...try/javaagent/instrumentation/vertx/reactive/server/VertxRxCircuitBreakerHttpServerTest.java Show resolved Hide resolved
...try/javaagent/instrumentation/vertx/reactive/server/VertxRxCircuitBreakerHttpServerTest.java Outdated Show resolved Hide resolved
...try/javaagent/instrumentation/vertx/reactive/server/VertxRxCircuitBreakerHttpServerTest.java Show resolved Hide resolved
@trask
Copy link
Member

trask commented Jan 28, 2025

Last part of #7195

😲

jaydeluca
jaydeluca approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jaydeluca jaydeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@trask trask merged commit e9227c3 into open-telemetry:main Jan 28, 2025
58 checks passed
@jaydeluca jaydeluca mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurit @trask @jaydeluca