Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract sender parameters to config carrier class #7151

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Feb 26, 2025

Related to #6718.

Reduces churn of the GrpcSenderProvider, HttpSenderProvider interfaces by extracting all config parameters into a carrier class, which can be extended with default implementations when new options are added.

#7152 would need to churn the API contract in order to accommodate the new ExecutorService parameter. Instead, because its built off of this PR, it can be done as a non-breaking change.

This will be important if we want to promote sender API to public as discussed in #6781.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.89%. Comparing base (31f484f) to head (7c2ce34).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...ry/exporter/internal/http/HttpExporterBuilder.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7151      +/-   ##
============================================
+ Coverage     89.87%   89.89%   +0.01%     
- Complexity     6623     6627       +4     
============================================
  Files           740      742       +2     
  Lines         20008    20047      +39     
  Branches       1968     1968              
============================================
+ Hits          17982    18021      +39     
  Misses         1437     1437              
  Partials        589      589              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 8efade6 into open-telemetry:main Mar 6, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants