Incubating: Add minimum severity and trace-based logger configuration #7529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2025
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Sep 23, 2025
…ers (#4612) Alternative to #4611 Some related prior discussions: - #4208 (comment) - #4207 (comment) Java POC @ open-telemetry/opentelemetry-java#7529 Declarative config for this is a bit nicer than in #4611, also supports applying different minimum severity levels to different loggers: ``` file_format: "1.0" logger_provider: logger_configurator/development: default_config: minimum_severity: WARN trace_based: true loggers: - name: "com.example.app.*" config: minimum_severity: INFO - name: "com.example.db.*" config: minimum_severity: ERROR ``` --------- Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
trask
force-pushed
the
minimum-severity-and-trace-based-log-configuration
branch
from
747bc91 to
f607dc9
Compare
trask
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7529 +/- ##
============================================
+ Coverage 90.17% 90.18% +0.01%
- Complexity 7189 7198 +9
============================================
Files 814 814
Lines 21730 21748 +18
Branches 2129 2132 +3
============================================
+ Hits 19594 19614 +20
- Misses 1467 1468 +1
+ Partials 669 666 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trask
force-pushed
the
minimum-severity-and-trace-based-log-configuration
branch
3 times, most recently
from
d8f0544 to
c471c04
Compare
trask
force-pushed
the
minimum-severity-and-trace-based-log-configuration
branch
from
c471c04 to
6d538c3
Compare
trask
commented
Oct 22, 2025
Comment on lines
39
to
47
| /** Returns a disabled {@link LoggerConfig}. */ | ||
| public static LoggerConfig disabled() { | ||
| return DISABLED_CONFIG; | ||
| } | ||
|
|
||
| /** Returns an enabled {@link LoggerConfig}. */ | ||
| public static LoggerConfig enabled() { | ||
| return DEFAULT_CONFIG; | ||
| } |
There was a problem hiding this comment.
do we want to keep these shortcuts? I'd lean towards removing them to avoid confusion that passing one of them at runtime only enables/disables (as opposed to resetting all the properties)
trask
commented
Oct 22, 2025
| .onEmit(context, createLogRecord(context, observedTimestampEpochNanos)); | ||
| } | ||
|
|
||
| protected ReadWriteLogRecord createLogRecord(Context context, long observedTimestampEpochNanos) { |
There was a problem hiding this comment.
extracted this so don't need to add
if (!logger.isEnabled(severity, context)) {
return;
}
to ExtendedSdkLogRecordBuilder
(you can thank codecov for pointing out to me that there was no test coverage for it in the subclass 😄)
trask
force-pushed
the
minimum-severity-and-trace-based-log-configuration
branch
from
ff37f15 to
7131c10
Compare
trask
force-pushed
the
minimum-severity-and-trace-based-log-configuration
branch
from
7131c10 to
a88392e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incubating implementation for open-telemetry/opentelemetry-specification#4612