-
Notifications
You must be signed in to change notification settings - Fork 914
allow configuration of throttling rate and time unit #7562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7562 +/- ##
============================================
- Coverage 90.02% 89.99% -0.03%
- Complexity 7080 7097 +17
============================================
Files 803 803
Lines 21417 21500 +83
Branches 2086 2087 +1
============================================
+ Hits 19280 19349 +69
- Misses 1475 1489 +14
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since the new configurations are for logs, would it be better under |
Will wait for the others to get back to me before I make changes for that, comments were left in an older PR that wasn't working properly: #7540 (comment) |
|
let's separate the programmatic configuration from the property-based one. I think @jack-berg is going to prefer that this get built into the new file-based configuration system, rather than adding new env vars/properties at this point. |
1420a75 to
40718db
Compare
40718db to
84a2913
Compare
New PR; accidentally discarded the commits for the branch used for the old PR: #7540
modified OtlpConfigUtil.java to take in:
otel.exporter.otlp.lograte
otel.exporter.otlp.throttledlograte
otel.exporter.otlp.logtimeunit
and configure the necessary values to set the log rate and throttled log rate for ThrottlingLogger.Java