Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detector-aws): add more lambda semconv attributes #2589

Merged
merged 15 commits into from
Feb 15, 2025

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented Dec 6, 2024

Which problem is this PR solving?

Adding extra attributes: aws.log.group.names, faas.instance, faas.max_memory

Short description of the changes

See above.

@garysassano garysassano requested a review from a team as a code owner December 6, 2024 01:08
Copy link

linux-foundation-easycla bot commented Dec 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from jj22ee December 6, 2024 01:08
@garysassano garysassano changed the title update aws lambda detector fix(detector-aws): update aws lambda detector Dec 6, 2024
@garysassano garysassano changed the title fix(detector-aws): update aws lambda detector feat(detector-aws): add attributes to aws lambda detector Jan 17, 2025
@garysassano garysassano force-pushed the upd-aws-detector branch 3 times, most recently from dfa4c57 to 766c412 Compare January 17, 2025 13:44
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (fd547c8) to head (e69318c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         171      171           
  Lines        8146     8150    +4     
  Branches     1654     1653    -1     
=======================================
+ Hits         7528     7532    +4     
  Misses        618      618           
Files with missing lines Coverage Δ
...etector-aws/src/detectors/AwsLambdaDetectorSync.ts 100.00% <100.00%> (ø)
...opentelemetry-resource-detector-aws/src/semconv.ts 100.00% <100.00%> (ø)

@garysassano garysassano changed the title feat(detector-aws): add attributes to aws lambda detector feat(detector-aws): add semconv attributes Jan 21, 2025
@garysassano garysassano changed the title feat(detector-aws): add semconv attributes feat(detector-aws): add more lambda semconv attributes Jan 21, 2025
@pichlermarc
Copy link
Member

cc @jj22ee, please take another look if you find the time 🙂

@jj22ee jj22ee added the has:owner-approval Approved by Component Owner label Feb 8, 2025
@pichlermarc pichlermarc merged commit bef920a into open-telemetry:main Feb 15, 2025
25 checks passed
@dyladan dyladan mentioned this pull request Feb 15, 2025
@garysassano garysassano deleted the upd-aws-detector branch February 15, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants