-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(detector-aws): add more lambda semconv attributes #2589
Merged
pichlermarc
merged 15 commits into
open-telemetry:main
from
garysassano:upd-aws-detector
Feb 15, 2025
Merged
feat(detector-aws): add more lambda semconv attributes #2589
pichlermarc
merged 15 commits into
open-telemetry:main
from
garysassano:upd-aws-detector
Feb 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj22ee
reviewed
Dec 10, 2024
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Outdated
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
dfa4c57
to
766c412
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 171 171
Lines 8146 8150 +4
Branches 1654 1653 -1
=======================================
+ Hits 7528 7532 +4
Misses 618 618
|
fed273c
to
85c7bf0
Compare
ca2fcf3
to
77c19b4
Compare
cc @jj22ee, please take another look if you find the time 🙂 |
jj22ee
reviewed
Feb 8, 2025
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
jj22ee
approved these changes
Feb 8, 2025
pichlermarc
approved these changes
Feb 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adding extra attributes:
aws.log.group.names
,faas.instance
,faas.max_memory
Short description of the changes
See above.