Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce diag.info when values are not required #5304

Closed
codefromthecrypt opened this issue Jan 8, 2025 · 4 comments · Fixed by #5360
Closed

reduce diag.info when values are not required #5304

codefromthecrypt opened this issue Jan 8, 2025 · 4 comments · Fixed by #5360
Labels
feature-request needs:code-contribution This feature/bug is ready to implement triage:accepted This feature has been accepted

Comments

@codefromthecrypt
Copy link

Is your feature request related to a problem? Please describe.

Right now, when I use the default exporter, for logs traces and metrics, I get a couple console statements from diag.info

OTEL_LOGS_EXPORTER is empty. Using default otlp exporter.
OTEL_TRACES_EXPORTER is empty. Using default otlp exporter.

It is frustrating to have to see this as it discourages using defaults. You might try to do something else just to get rid of the output.

Describe the solution you'd like

I would like to not see things in console output about using defaults, and not have to adjust diag settings to do so.

Describe alternatives you've considered

there are also some glitches trying to set the level from info to warning to avoid the same. Looks like this:

Current logger will be overwritten from Error
--snip
Current logger will overwrite one already registered from Error
--snip

Additional context

related issue about undesired output when attempting to change the diag level to warning #4447

@pichlermarc
Copy link
Member

Hi - yep i think we should not use info in that case.
Let's change it to debug - @codefromthecrypt would that solve the issue?

@codefromthecrypt
Copy link
Author

weird I thought I had made a reply. yes I think debug would be better.

@pichlermarc pichlermarc added triage:accepted This feature has been accepted needs:code-contribution This feature/bug is ready to implement up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jan 20, 2025
@pichlermarc
Copy link
Member

Alright, then let's change these to debug. 👍
Marking this as up-for-grabs in case anyone has time to work on it.

cjihrig added a commit to cjihrig/opentelemetry-js that referenced this issue Jan 23, 2025
This commit lowers the diagnostic level to debug when
exporters are not explicitly provided and the default is used.

Fixes: open-telemetry#5304
cjihrig added a commit to cjihrig/opentelemetry-js that referenced this issue Jan 23, 2025
This commit lowers the diagnostic level to debug when
exporters are not explicitly provided and the default is used.

Fixes: open-telemetry#5304
@pichlermarc pichlermarc removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 23, 2025
@codefromthecrypt
Copy link
Author

hey thanks for beating me to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request needs:code-contribution This feature/bug is ready to implement triage:accepted This feature has been accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants