Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-node): lower diagnostic level #5360

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 23, 2025

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5304

Short description of the changes

This commit lowers the diagnostic level to debug when exporters are not explicitly provided and the default is used.

(Note - there are a couple other similar logs like 'OTEL_TRACES_EXPORTER contains "none". SDK will not be initialized.' but I was not sure if they should be updated too.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran the test suite.
  • Changed the log level of the modified test to 'debug' and verified that the previous logs were restored. I'm not sure if this is something that a unit test is desirable for, but I can add one if people think it is a good idea.

Checklist:

  • Followed the style guidelines of this project

@cjihrig cjihrig requested a review from a team as a code owner January 23, 2025 05:58
This commit lowers the diagnostic level to debug when
exporters are not explicitly provided and the default is used.

Fixes: open-telemetry#5304
@pichlermarc pichlermarc changed the title refactor(opentelemetry-sdk-node): lower diagnostic level feat(sdk-node): lower diagnostic level Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.54%. Comparing base (c00f36e) to head (91272b8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5360   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         318      318           
  Lines        8051     8051           
  Branches     1694     1694           
=======================================
  Hits         7612     7612           
  Misses        439      439           
Files with missing lines Coverage Δ
...ental/packages/opentelemetry-sdk-node/src/utils.ts 88.23% <100.00%> (ø)
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 96.01% <50.00%> (ø)

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

experimental/CHANGELOG.md Outdated Show resolved Hide resolved
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 23, 2025

@pichlermarc is there anything else I need to do on this? I notice codecov is failing.

@pichlermarc
Copy link
Member

@pichlermarc is there anything else I need to do on this? I notice codecov is failing.

No, all good. Codecov is failing because this line was not covered by tests, but they were already not covered before you opened your PR so no need to take any action.

@pichlermarc pichlermarc added this pull request to the merge queue Jan 23, 2025
Merged via the queue into open-telemetry:main with commit b4ae9ca Jan 23, 2025
14 of 15 checks passed
@cjihrig cjihrig deleted the level branch January 24, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce diag.info when values are not required
2 participants