Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-node): lower diagnostic level #5360

Merged
merged 2 commits into from
Jan 23, 2025
Merged

feat(sdk-node): lower diagnostic level #5360

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b4dd3
refactor(opentelemetry-sdk-node): lower diagnostic level
cjihrig Jan 23, 2025
91272b8
Update experimental/CHANGELOG.md
pichlermarc Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ All notable changes to experimental packages in this project will be documented
### :rocket: (Enhancement)

* feat(instrumentation): re-export initialize function from import-in-the-middle [#5123](https://github.com/open-telemetry/opentelemetry-js/pull/5123)
* refactor(opentelemetry-sdk-node): lower diagnostic level [#5360](https://github.com/open-telemetry/opentelemetry-js/pull/5360) @cjihrig
pichlermarc marked this conversation as resolved.
Show resolved Hide resolved

### :bug: (Bug Fix)

Expand Down
4 changes: 2 additions & 2 deletions experimental/packages/opentelemetry-sdk-node/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
const enabledExporters = filterBlanksAndNulls(metricsExporterList.split(','));

if (enabledExporters.length === 0) {
diag.info('OTEL_METRICS_EXPORTER is empty. Using default otlp exporter.');
diag.debug('OTEL_METRICS_EXPORTER is empty. Using default otlp exporter.');

Check warning on line 119 in experimental/packages/opentelemetry-sdk-node/src/sdk.ts

View check run for this annotation

Codecov / codecov/patch

experimental/packages/opentelemetry-sdk-node/src/sdk.ts#L119 

Added line #L119 was not covered by tests
}

if (enabledExporters.includes('none')) {
Expand Down Expand Up @@ -449,7 +449,7 @@
const enabledExporters = filterBlanksAndNulls(logExportersList.split(','));

if (enabledExporters.length === 0) {
diag.info('OTEL_LOGS_EXPORTER is empty. Using default otlp exporter.');
diag.debug('OTEL_LOGS_EXPORTER is empty. Using default otlp exporter.');
enabledExporters.push('otlp');
}

Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-sdk-node/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export function getSpanProcessorsFromEnv(): SpanProcessor[] {
}

if (traceExportersList.length === 0) {
diag.warn('OTEL_TRACES_EXPORTER is empty. Using default otlp exporter.');
diag.debug('OTEL_TRACES_EXPORTER is empty. Using default otlp exporter.');
traceExportersList = ['otlp'];
} else if (
traceExportersList.length > 1 &&
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ describe('Node SDK', () => {
sdk.start();
assert.ok(!(metrics.getMeterProvider() instanceof MeterProvider));
assert.strictEqual(
stubLogger.args[1][0],
stubLogger.args[0][0],
'OTEL_METRICS_EXPORTER contains "none". Metric provider will not be initialized.'
);
await sdk.shutdown();
Expand Down
Loading