[chore] change JSON marshaler to goccy-json #3660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
change_json_marshaler
branch
from
c6c6626 to
928c757
Compare
swiatekm
reviewed
Jan 29, 2025
Comment on lines
-54
to
-56
| EscapeHTML: false, | ||
| MarshalFloatWith6Digits: true, | ||
| ObjectFieldMustBeSimpleString: true, |
There was a problem hiding this comment.
Do you know how go-json behaves when it comes to these settings?
There was a problem hiding this comment.
it follows the same best practices as encoding/json. It doesn't cut any corners.
I assume test coverage would catch any regressions related to this change, is that an incorrect assumption?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
jsoniter is no longer maintained; this PR switches over to github.com/goccy/go-json