Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add shellcheck to CI #3664

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 25, 2025

Description:
add shellcheck to CI to check .ci and hack folders.

Link to tracking Issue(s):
Fixes #3647

@atoulme atoulme requested a review from a team as a code owner January 25, 2025 08:12
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would've been nicer to add a make target, but we change these scripts rarely enough that it's probably not worth it.

name: shellcheck
runs-on: ubuntu-24.04
env:
VERSION: v0.10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure renovate updates this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can open an issue for it, I don't know how to do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3676 is open

@swiatekm swiatekm self-requested a review January 28, 2025 10:11
@swiatekm swiatekm merged commit 8d5900a into open-telemetry:main Jan 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider running shellcheck as part of CI
2 participants