implement SpanProcessor::onEnding #1483
Merged
+225
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added to spec 1.36.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1483 +/- ##
============================================
+ Coverage 70.49% 70.57% +0.07%
- Complexity 2792 2797 +5
============================================
Files 413 413
Lines 8416 8428 +12
============================================
+ Hits 5933 5948 +15
+ Misses 2483 2480 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Nevay
reviewed
Jan 23, 2025
cached vendor dir was causing havoc with a conflict between vendor and vendor-bin/psalm (amphp/amp)
brettmc
force-pushed
the
span-processor-onending
branch
from
74ec0fd to
e7570c4
Compare
brettmc
commented
Jan 28, 2025
| @@ -3,5 +3,8 @@ | |||
| "vimeo/psalm": "^5.24", | |||
| "psalm/plugin-mockery": "^1", | |||
| "psalm/plugin-phpunit": "^0.18.4" | |||
| }, | |||
| "replace": { | |||
| "amphp/amp": "*" | |||
There was a problem hiding this comment.
This avoids a conflict between vendor-bin/psalm's version of amp conflicting with the dev dependency.
Nevay
suggested changes
Jan 28, 2025
remove pass-by-reference, and add an integration test for mutating span in OnEnding
now a clone rather than the original span is passed to onEnd
Nevay
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added to spec 1.36.0