Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove todo for logging dropped attributes #1485

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 23, 2025

this is already implemented for logs and traces as required by spec

this is already implemented for logs and traces as required by spec
@brettmc brettmc requested a review from a team as a code owner January 23, 2025 04:33
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.65%. Comparing base (7eb3abb) to head (8ca21af).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1485      +/-   ##
============================================
- Coverage     70.71%   70.65%   -0.06%     
  Complexity     2761     2761              
============================================
  Files           408      408              
  Lines          8341     8341              
============================================
- Hits           5898     5893       -5     
- Misses         2443     2448       +5     
Flag Coverage Δ
8.1 70.35% <ø> (-0.09%) ⬇️
8.2 70.59% <ø> (+0.02%) ⬆️
8.3 70.56% <ø> (-0.08%) ⬇️
8.4 70.60% <ø> (+0.02%) ⬆️
8.5 70.59% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Common/Attribute/AttributesBuilder.php 80.95% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb3abb...8ca21af. Read the comment docs.

@brettmc brettmc merged commit e3f77b7 into open-telemetry:main Jan 29, 2025
10 of 11 checks passed
@brettmc brettmc deleted the remove-attribute-todo branch January 29, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants