Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate semconv 1.28 #1491

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jan 28, 2025

No description provided.

@brettmc brettmc requested a review from a team as a code owner January 28, 2025 04:50
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.66%. Comparing base (7eb3abb) to head (ebea409).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1491      +/-   ##
============================================
- Coverage     70.71%   70.66%   -0.05%     
  Complexity     2761     2761              
============================================
  Files           408      408              
  Lines          8341     8341              
============================================
- Hits           5898     5894       -4     
- Misses         2443     2447       +4     
Flag Coverage Δ
8.1 70.36% <ø> (-0.08%) ⬇️
8.2 70.60% <ø> (+0.03%) ⬆️
8.3 70.59% <ø> (-0.05%) ⬇️
8.4 70.57% <ø> (-0.01%) ⬇️
8.5 70.61% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SemConv/Version.php 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb3abb...ebea409. Read the comment docs.

Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to add the new version here too? 👍

@ChrisLightfootWild ChrisLightfootWild requested a review from a team January 29, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants