Skip to content

Commit

Permalink
add TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb committed Nov 26, 2024
1 parent 6dac98d commit 695b45b
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 0 deletions.
17 changes: 17 additions & 0 deletions opentelemetry-stackdriver/proto/google/api/client.proto
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ message CommonLanguageSettings {

// The destination where API teams want this client library to be published.
repeated ClientLibraryDestination destinations = 2;

// Configuration for which RPCs should be generated in the GAPIC client.
SelectiveGapicGeneration selective_gapic_generation = 3;
}

// Details about how and where to publish client libraries.
Expand Down Expand Up @@ -272,6 +275,12 @@ message PythonSettings {
// This feature will be enabled by default 1 month after launching the
// feature in preview packages.
bool rest_async_io_enabled = 1;

// Enables generation of protobuf code using new types that are more
// Pythonic which are included in `protobuf>=5.29.x`. This feature will be
// enabled by default 1 month after launching the feature in preview
// packages.
bool protobuf_pythonic_types_enabled = 2;
}

// Some settings.
Expand Down Expand Up @@ -443,3 +452,11 @@ enum ClientLibraryDestination {
// Publish the library to package managers like nuget.org and npmjs.com.
PACKAGE_MANAGER = 20;
}

// This message is used to configure the generation of a subset of the RPCs in
// a service for client libraries.
message SelectiveGapicGeneration {
// An allowlist of the fully qualified names of RPCs that should be included
// on public client surfaces.
repeated string methods = 1;
}
18 changes: 18 additions & 0 deletions opentelemetry-stackdriver/src/proto/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,9 @@ pub struct CommonLanguageSettings {
/// The destination where API teams want this client library to be published.
#[prost(enumeration = "ClientLibraryDestination", repeated, tag = "2")]
pub destinations: ::prost::alloc::vec::Vec<i32>,
/// Configuration for which RPCs should be generated in the GAPIC client.
#[prost(message, optional, tag = "3")]
pub selective_gapic_generation: ::core::option::Option<SelectiveGapicGeneration>,
}
/// Details about how and where to publish client libraries.
#[derive(Clone, PartialEq, ::prost::Message)]
Expand Down Expand Up @@ -609,6 +612,12 @@ pub mod python_settings {
/// feature in preview packages.
#[prost(bool, tag = "1")]
pub rest_async_io_enabled: bool,
/// Enables generation of protobuf code using new types that are more
/// Pythonic which are included in `protobuf>=5.29.x`. This feature will be
/// enabled by default 1 month after launching the feature in preview
/// packages.
#[prost(bool, tag = "2")]
pub protobuf_pythonic_types_enabled: bool,
}
}
/// Settings for Node client libraries.
Expand Down Expand Up @@ -743,6 +752,15 @@ pub mod method_settings {
pub total_poll_timeout: ::core::option::Option<::prost_types::Duration>,
}
}
/// This message is used to configure the generation of a subset of the RPCs in
/// a service for client libraries.
#[derive(Clone, PartialEq, ::prost::Message)]
pub struct SelectiveGapicGeneration {
/// An allowlist of the fully qualified names of RPCs that should be included
/// on public client surfaces.
#[prost(string, repeated, tag = "1")]
pub methods: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
}
/// The organization for which the client libraries are being published.
/// Affects the url where generated docs are published, etc.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, ::prost::Enumeration)]
Expand Down
2 changes: 2 additions & 0 deletions opentelemetry-stackdriver/src/proto/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// TODO Remove below allow once proto files are fixed
#[allow(clippy::doc_markdown, clippy::doc_lazy_continuation)]
pub mod api;

pub mod devtools {
Expand Down

0 comments on commit 695b45b

Please sign in to comment.