Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[user_events logs] Remove Arc reference from eventheader provider #143

Merged
merged 4 commits into from
Jan 9, 2025
Merged

[user_events logs] Remove Arc reference from eventheader provider #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
faa760f
initial commit
lalitb Dec 16, 2024
56fb9b9
Merge branch 'main' into remove-arc-provide-ue-logs
lalitb Dec 17, 2024
133a5df
update stress result
lalitb Dec 17, 2024
2e9fa5c
Merge branch 'main' into remove-arc-provide-ue-logs
lalitb Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions opentelemetry-user-events-logs/src/logs/exporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
use std::borrow::Cow;
use std::collections::HashMap;
use std::fmt::Debug;
use std::sync::Arc;

use opentelemetry::{logs::AnyValue, logs::Severity, Key};
use std::{cell::RefCell, str, time::SystemTime};
Expand Down Expand Up @@ -49,7 +48,7 @@

/// UserEventsExporter is a log exporter that exports logs in EventHeader format to user_events tracepoint.
pub struct UserEventsExporter {
provider: Arc<eventheader_dynamic::Provider>,
provider: eventheader_dynamic::Provider,
exporter_config: ExporterConfig,
}

Expand All @@ -70,7 +69,7 @@
eventheader_dynamic::Provider::new(provider_name, &options);
Self::register_keywords(&mut eventheader_provider, &exporter_config);
UserEventsExporter {
provider: Arc::new(eventheader_provider),
provider: eventheader_provider,

Check warning on line 72 in opentelemetry-user-events-logs/src/logs/exporter.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-user-events-logs/src/logs/exporter.rs#L72 

Added line #L72 was not covered by tests
exporter_config,
}
}
Expand Down
16 changes: 8 additions & 8 deletions stress/src/user_events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
//!
// Conf - AMD EPYC 7763 64-Core Processor 2.44 GHz, 64GB RAM, Cores:8 , Logical processors: 16
// Stress Test Results (user_events disabled)
// Threads: 1 - Average Throughput: 30,866,752 iterations/sec
// Threads: 5 - Average Throughput: 32,662,641 iterations/sec
// Threads: 10 - Average Throughput: 25,776,394 iterations/sec
// Threads: 16 - Average Throughput: 16,915,860 iterations/sec
// Threads: 1 - Average Throughput: 42,086,520 iterations/sec
// Threads: 5 - Average Throughput: 35,767,375 iterations/sec
// Threads: 10 - Average Throughput: 29,189,340 iterations/sec
// Threads: 16 - Average Throughput: 19,579,138 iterations/sec

// Stress Test Results (user_events enabled)
// Threads: 1 - Average Throughput: 212,594 iterations/sec
// Threads: 5 - Average Throughput: 372,695 iterations/sec
// Threads: 10 - Average Throughput: 277,675 iterations/sec
// Threads: 16 - Average Throughput: 268,940 iterations/sec
// Threads: 1 - Average Throughput: 285,692 iterations/sec
// Threads: 5 - Average Throughput: 392,906 iterations/sec
// Threads: 10 - Average Throughput: 349,334 iterations/sec
// Threads: 16 - Average Throughput: 297,232 iterations/sec

use opentelemetry_appender_tracing::layer;
use opentelemetry_sdk::logs::LoggerProvider;
Expand Down
Loading