-
Notifications
You must be signed in to change notification settings - Fork 525
feat: add shutdown with timeout for log exporter #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shutdown with timeout for log exporter #2909
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2909 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 126 126
Lines 24254 24251 -3
=====================================
Hits 19736 19736
+ Misses 4518 4515 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4c2ed45
to
c590dc8
Compare
c590dc8
to
cd478d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction is good, we just need to avoid breaking changes
https://github.com/open-telemetry/opentelemetry-rust/pull/2909/files#r2044826171
8fb6ecf
to
d776d6c
Compare
The changes look good. We still don't have complete flow to have this invoked from provider/processor. Will that be added as separate PR? |
Yes,I will do that in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#2574 Part 3: Adding shutdown_with_timeout for log exporter