Skip to content

feat: add shutdown with timeout for log exporter #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mohammadVatandoost
Copy link
Contributor

#2574 Part 3: Adding shutdown_with_timeout for log exporter

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner April 7, 2025 19:10
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (d7f8244) to head (5d49b9a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/simple_log_processor.rs 0.0% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/tonic/logs.rs 0.0% 1 Missing ⚠️
opentelemetry-otlp/src/logs.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/logs/logger_provider.rs 0.0% 1 Missing ⚠️
opentelemetry-stdout/src/logs/exporter.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2909   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        126     126           
  Lines      24254   24251    -3     
=====================================
  Hits       19736   19736           
+ Misses      4518    4515    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mohammadVatandoost mohammadVatandoost force-pushed the add-shutdown-with-timeout-for-log-exporter branch 2 times, most recently from 4c2ed45 to c590dc8 Compare April 7, 2025 19:21
@mohammadVatandoost mohammadVatandoost force-pushed the add-shutdown-with-timeout-for-log-exporter branch from c590dc8 to cd478d0 Compare April 7, 2025 19:28
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction is good, we just need to avoid breaking changes
https://github.com/open-telemetry/opentelemetry-rust/pull/2909/files#r2044826171

@mohammadVatandoost mohammadVatandoost force-pushed the add-shutdown-with-timeout-for-log-exporter branch from 8fb6ecf to d776d6c Compare April 16, 2025 15:37
@lalitb
Copy link
Member

lalitb commented Apr 16, 2025

The changes look good. We still don't have complete flow to have this invoked from provider/processor. Will that be added as separate PR?

@mohammadVatandoost
Copy link
Contributor Author

The changes look good. We still don't have complete flow to have this invoked from provider/processor. Will that be added as separate PR?

Yes,I will do that in a separate PR

@cijothomas cijothomas dismissed their stale review April 21, 2025 18:10

breaking change removed

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 5c60f12 into open-telemetry:main Apr 22, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants