-
Notifications
You must be signed in to change notification settings - Fork 66
Internal Telemetry Guidelines #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
b844ccc
Remove redundant metrics
lquerel 5b379ae
Add SEMANTIC_CONVENTIONS_GUIDE.md
lquerel 2d01d29
Organize telemetry documentation
lquerel f70bfb3
Update entity-model.md
lquerel 6ec0052
Update entity-model.md
lquerel 56ef0fe
Update entity-model.md
lquerel e74191c
Update entity-model.md
lquerel 44d2b98
Update README.md
lquerel bf8bc95
Add metrics-guide.md
lquerel d7e4720
Update README.md
lquerel a58942a
Update metrics-guide.md
lquerel 43f5788
Update events-guide.md
lquerel 16b8bb4
Update telemetry guides
lquerel e375cf1
Update telemetry README.md
lquerel 7e7b7b2
Several updates in the document based on feedback
lquerel a7a14f7
Fix markdown issues
lquerel 529047c
Add stability, compatibility, safety recommendations
lquerel 2a72f07
Add 3 new guides on attributes, stability, and security/privacy
lquerel 348fac4
Identify implementation gaps
lquerel 96105e8
Remove content duplication
lquerel 06c9b29
Clarify tracing status
lquerel 51303e4
Fix markdown issues
lquerel 986c300
Additional edits in the doc for improving consistency and clarity
lquerel c8d10bf
Unify title styles
lquerel 161b209
Fix few missing/unclear points
lquerel ba507ee
Merge branch 'main' into metrics-cleanup
lquerel d69fb41
Few minor changes in the README.md
lquerel 918233a
Few minor changes in the main README.md
lquerel 4fe4bb3
Update admin endpoints security requirements
lquerel a493c22
Update rust/otap-dataflow/docs/telemetry/security-privacy-guide.md
lquerel 91022dd
Merge branch 'main' into metrics-cleanup
lquerel 57e4f67
Take into account all feedback
lquerel 2a825de
Fix markdown issues
lquerel 3642d55
Fix markdown issues
lquerel c709fd1
Fix markdown issues
lquerel 4d676c5
Fix markdown issues
lquerel 9831aab
Fix markdown issues
lquerel 2bb7677
Fix markdown issues
lquerel bd82699
Merge branch 'main' into metrics-cleanup
lquerel c284533
Fix clippy issues
lquerel 4f67d3b
Merge remote-tracking branch 'origin/metrics-cleanup' into metrics-cl…
lquerel 3e1884f
Fix unit test
lquerel a5ec1ee
Fix unit test
lquerel 87ffa22
Fix unit test
lquerel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,17 +7,9 @@ use otap_df_telemetry::instrument::Counter; | |
| use otap_df_telemetry_macros::metric_set; | ||
|
|
||
| /// Metrics for the TransformProcessor node. | ||
| #[metric_set(name = "transform.processor.metrics")] | ||
| #[metric_set(name = "transform.processor")] | ||
| #[derive(Debug, Default, Clone)] | ||
| pub struct Metrics { | ||
| /// PData messages consumed by this processor. | ||
| #[metric(unit = "{msg}")] | ||
| pub msgs_consumed: Counter<u64>, | ||
|
|
||
| /// PData messages forwarded by this processor. | ||
| #[metric(unit = "{msg}")] | ||
| pub msgs_forwarded: Counter<u64>, | ||
|
|
||
|
Comment on lines
-13
to
-20
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed because redundant with the channel metrics. |
||
| /// Number of messages successfully transformed. | ||
| #[metric(unit = "{msg}")] | ||
| pub msgs_transformed: Counter<u64>, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed because redundant with the channel metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Its easier from review standpoint, to keep PRs more focused. Since this PR is adding telemetry guidelines doc, lets stick with that. Cleaning up metrics can be own PR.