-
Notifications
You must be signed in to change notification settings - Fork 67
Internal logging configuration model, background thread(s) #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
7d91076
51e6559
00cdb25
0aaad0b
d8c7ac2
0c44470
58e988b
52a9610
7cb9db8
b374a47
cd80b0e
c7a7d0b
ce6a95b
165c940
686cd9e
21961df
8f8595c
f9a65a5
b95aea2
82f5cbe
cd4baee
f8f0eb7
92a9337
d80edc6
4e4b37f
657524d
cbb1000
2f02db6
ba09b56
c172e5d
60fea89
b9e8958
a6b6f46
983518f
241158e
93c118e
e235e85
54d6bf4
e1e52c8
7a1baed
9e86542
f277f09
1eba8f2
af37863
16fe056
f25ed91
476303b
58af27d
cbf9f26
53b1cc4
d031e42
d6b6610
dd8ed6e
33ad2dc
faa45be
d1b26ad
ecaf623
20a7831
a0563a6
ec57fb0
33a699a
7de5313
cca289b
9a760eb
bcfe275
0e15ab8
a3cf629
70c42dc
4f8851a
c0023dc
11f64d0
f24f3e9
7bc5932
93ef680
4521ae7
31dbd95
97c7ae0
7d4672b
e3d99fe
766aa9f
a760279
a6e680d
5819b3a
c1d751c
c14ddfe
f87d005
946f55a
32a62c4
7748e72
4c4b4bf
c4a7e8a
1feacae
63b9edc
e794c79
fac9460
6515c93
44bbfd5
cbda0ef
daa127c
aa50128
86dfc31
db8de3e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,3 +51,12 @@ nodes: | |
| kind: exporter | ||
| plugin_urn: "urn:otel:noop:exporter" | ||
| config: | ||
|
|
||
| service: | ||
| telemetry: | ||
| logs: | ||
| level: "debug" | ||
| providers: | ||
| global: immediate | ||
| engine: immediate | ||
| output: direct | ||
|
Comment on lines
+60
to
+62
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this mean? |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| settings: | ||
| default_pipeline_ctrl_msg_channel_size: 100 | ||
| default_node_ctrl_msg_channel_size: 100 | ||
| default_pdata_channel_size: 100 | ||
|
|
||
| nodes: | ||
| receiver: | ||
| kind: receiver | ||
| plugin_urn: "urn:otel:otap:fake_data_generator:receiver" | ||
| out_ports: | ||
| out_port: | ||
| destinations: | ||
| - debug | ||
| dispatch_strategy: round_robin | ||
| config: | ||
| traffic_config: | ||
| max_signal_count: 100000 | ||
| max_batch_size: 1000 | ||
| signals_per_second: 1000 | ||
| log_weight: 100 | ||
| registry_path: https://github.com/open-telemetry/semantic-conventions.git[model] | ||
| debug: | ||
| kind: processor | ||
| plugin_urn: "urn:otel:debug:processor" | ||
| out_ports: | ||
| out_port: | ||
| destinations: | ||
| - noop | ||
| dispatch_strategy: round_robin | ||
| config: | ||
| verbosity: basic | ||
| noop: | ||
| kind: exporter | ||
| plugin_urn: "urn:otel:noop:exporter" | ||
| config: {} | ||
|
|
||
| # Internal telemetry pipeline - separate from main pipeline | ||
| # Uses hardcoded settings: single thread, no admin server | ||
| internal: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: We can make it multi-graph with the same effort and risk. graphs: # array of graphs
- internal: # name of the graph
# other graph level properties, including the logger type
nodes: # copied from the original graph structure
telemetry: # same block that is configured here
...We can keep the existing configuration of single graph as is. This would be more an extension of the configuration. |
||
| telemetry: | ||
| kind: receiver | ||
| plugin_urn: "urn:otel:internal:otlp:receiver" | ||
| out_ports: | ||
| out_port: | ||
| destinations: | ||
| - batch | ||
| dispatch_strategy: round_robin | ||
| config: {} | ||
| batch: | ||
| kind: processor | ||
| plugin_urn: "urn:otel:batch:processor" | ||
| out_ports: | ||
| out_port: | ||
| destinations: | ||
| - console | ||
| dispatch_strategy: round_robin | ||
| config: | ||
| otap: | ||
| min_size: 1000 | ||
| sizer: items | ||
| flush_timeout: 3s | ||
| format: preserve | ||
| console: | ||
| kind: exporter | ||
| plugin_urn: "urn:otel:console:exporter" | ||
| config: {} | ||
|
|
||
| service: | ||
| telemetry: | ||
| logs: | ||
| level: "debug" | ||
| providers: | ||
| global: immediate | ||
| engine: immediate | ||
| internal: raw # Avoid feedback in internal pipeline | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be configured at the "internal" block, not really here |
||
| output: internal | ||
| resource: | ||
| service.id: 1234 | ||
| service.name: test | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more for the existing SDK configuration, in alignment with the otel collector style.
I would configure it in /telemetry/logs instead if required.