Skip to content

Conversation

@jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 15, 2026

Part of #1771.

Part of #1736.

Follows #1741.

This raw_error! macro is different from the others in internal_events.rs in two ways:

  1. Supports the complete Tokio tracing syntax, including display and debug formatters
  2. Bypasses the Tokio global dispatch and subscriber, calling into the raw logging layer

The use of tracing's valueset! macro is key to supporting the whole syntax for the other otel_XXX! macros.

Test log statement prints:

2026-01-15T20:59:42.100Z  ERROR  otap_df_telemetry::internal_events::tests::raw error message (crates/telemetry/src/internal_events.rs:171):  [error=ConfigurationError("bad config")]

@jmacd jmacd requested a review from a team as a code owner January 15, 2026 20:58
@jmacd jmacd changed the title Internal logging raw_error! macro suppor Internal logging raw_error! macro support Jan 15, 2026
@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.34%. Comparing base (d7abcd3) to head (70c905c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
+ Coverage   84.33%   84.34%   +0.01%     
==========================================
  Files         495      496       +1     
  Lines      144350   144363      +13     
==========================================
+ Hits       121740   121769      +29     
+ Misses      22076    22060      -16     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 85.61% <95.23%> (+0.01%) ⬆️
query_abstraction 80.61% <ø> (ø)
query_engine 90.52% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 89.81% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd added this pull request to the merge queue Jan 16, 2026
Merged via the queue into open-telemetry:main with commit 5e2ee27 Jan 16, 2026
43 checks passed
@jmacd jmacd deleted the jmacd/raw_error_3 branch January 16, 2026 04:54
}};
}

mod tests {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod tests should be placed under #[cfg(test)].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants