-
Notifications
You must be signed in to change notification settings - Fork 17
Dev multi port traffic #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…fic-generator/models into dev-multi-port-traffic
@@ -43,10 +43,14 @@ components: | |||
- '/components/schemas/Port/properties/name' | |||
- '/components/schemas/Lag/properties/name' | |||
x-field-uid: 1 | |||
rx_name: | |||
rx_names: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks backward compatibility for all port based tests.
Some options to mitigate broken tests would be:
- deprecate the rx_name property for a few releases and at the same time introduce rx_names
- introduce a new choice called ports which will have rx_names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I will keep the rx_name property in deprecated state for few releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajbalogh I have updated and retained rx_name property in deprecated state.
The processing of get metrics response is captured here @ashutshkumr FYI. |
@ajbalogh there had been some internal discussions whether we need the multiple Rx port support (raw traffic) in the immediate future, and it was decided we will port some of the target FP testcases to use device traffic instead (for which multiple Rx port support is already present in model). We will park this PR for the time being. |
@anjan-keysight @ashutshkumr let's define if this has to be settled before v1.0 release. Or put it the other way, if we mark |
Traffic support on multiple Rx ports.