Skip to content

WorkflowDefinition should be accesible from Flow #1291

Description

@fjtirado

Flow class is a decorator of WorkflowDefinition class.
There are some scenarios (for example, accessing the list of scheduled instances) where will be useful to access the WorkflowDefinition wrapped by the Flow class.
I propose, rather than adding those method and call the definition internally, to expose directly WorkflowDefinition by making this method public
This makes sense because, after all, WorlfkowDefinition is injectable, so there is not really a big deal making it public in Flow.
By the way, talking about method scope, init method in Flow class should be probably not public.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions