Repository navigation
WorkflowDefinition crashes when workflow has no tasks #1593
Description
Activity
A workflow definition must have tasks.
Therefore a definition without task is invalid and it is ok to throw a runtime exception when it is executed.
The safeguards should be added in the APIS that generates the wrong workflow.While investigating this issue, I found two related problems:
1.
WorkflowReader.defaultReader()skips validationdefaultReader()returnsNoValidationHolder.instanceinstead ofValidationHolder.instance, so workflows are never validated against the schema by default. After fixing this, several tests fail
because their YAML files aren't schema-compliant.2. Local schema is outdated
types/src/main/resources/schema/workflow.yamlis out of sync with the upstream specification schema.Items to address:
- Fix
defaultReader()to useValidationHolder(validate by default) - Sync local schema with upstream specification
- Fix test YAML files to pass validation
- Guard
processTaskListfrom null/empty task lists (original issue)
- Fix
Schema and default readed has been updated. This one should be used to validate DSL
Creating a WorkflowDefinition from a Workflow with an empty task list causes a crash.
Steps to reproduce:
Actual behavior:
TaskExecutorHelper.createExecutorList() calls iterator.next() without checking hasNext() on the empty task map, resulting in a NoSuchElementException.