-
Notifications
You must be signed in to change notification settings - Fork 2
Allow customization of ActiveStorage storage #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arkirchner
wants to merge
6
commits into
main
Choose a base branch
from
ak/s3_for_active_storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the production environment, an alternative S3-compatible storage provider can be configured. Related to #2104
183e172
to
e5c7311
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 134 134
Lines 3421 3421
=======================================
Hits 3242 3242
Misses 179 179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MrSerth
reviewed
Aug 18, 2025
Co-authored-by: Sebastian Serth <[email protected]>
MrSerth
reviewed
Aug 18, 2025
Co-authored-by: Sebastian Serth <[email protected]>
Co-authored-by: Sebastian Serth <[email protected]>
[memo] Do not merge until the deployment pipeline with the new config is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the production environment, an alternative S3-compatible storage provider can be configured.
Related to #2104