fix: github workflow by setting up jdk 17 #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratyushSingh07
force-pushed
the
workflow-fix
branch
from
8525aa7 to
576fe05
Compare
|
Hey @therajanmaurya I have fixed the CI/CD of this project . Do review this. I believe merging this into our codebase will be a great addition !! |
PratyushSingh07
changed the title
therajanmaurya
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1433
Screenshots
Description
mifospaymodule . This was important because the PMD check was failing on this module because of the below mentioned unused imports