fix: add DoS protection to OpenAI API calls#489
Open
deosha wants to merge 1 commit intoopenai:mainfrom
Open
Conversation
- Add configurable timeout (OPENAI_TIMEOUT env var, default 30s) - Add max_tokens limit (MAX_TOKENS env var, default 500) - Add input length validation (MAX_INPUT_LENGTH env var, default 10000 chars) - Prevents API abuse and cost explosion from large/malicious inputs Identified using aisentry (https://aisentry.co)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds DoS protection to the
get_chat_completionfunction to prevent API abuse and cost explosion.The Problem
The
get_chat_completion()function inservices/openai.pylacks:This allows attackers to send extremely large inputs or trigger expensive API calls without limits.
The Fix
Added configurable protections:
OPENAI_TIMEOUT- Request timeout (default: 30 seconds)MAX_TOKENS- Maximum response tokens (default: 500)MAX_INPUT_LENGTH- Maximum input characters (default: 10,000)All settings are configurable via environment variables for flexibility.
Changes
Identified using aisentry, an AI/LLM security scanner for OWASP LLM Top 10 vulnerabilities.