Skip to content

fix: widen /codex:review wait threshold to ~5 files / 200 lines #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertbpugh wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix: widen /codex:review wait threshold to ~5 files / 200 lines #315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d0000
fix: widen /codex:review wait threshold to ~5 files / 200 lines
robertbpugh May 11, 2026
8b358db
Potential fix for pull request finding
robertbpugh May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/codex/commands/review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Execution mode rules:
- For base-branch review, use `git diff --shortstat <base>...HEAD`.
- Treat untracked files or directories as reviewable work even when `git diff --shortstat` is empty.
- Only conclude there is nothing to review when the relevant working-tree status is empty or the explicit branch diff is empty.
- Recommend waiting only when the review is clearly tiny, roughly 1-2 files total and no sign of a broader directory-sized change.
- Recommend waiting when the review is small, roughly up to 5 files or 200 lines of diff, with no sign of a broader directory-sized change. Codex finishes within Claude's prompt cache window (5 minutes) for diffs of this size, so wait in the foreground and the result feeds the next step.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Gate foreground recommendation on both size thresholds

Using or here makes large diffs qualify as “wait” whenever just one dimension is small (for example, a 1-file/1500-line refactor or a 9-file/80-line sweep), which contradicts the stated “small review” intent and can push long reviews into foreground mode where the user is blocked and cache-window assumptions no longer hold. The recommendation should require both limits (or an equivalent combined smallness check), not either one independently.

Useful? React with 👍 / 👎.

Comment thread
robertbpugh marked this conversation as resolved.
Outdated
- In every other case, including unclear size, recommend background.
- When in doubt, run the review instead of declaring that there is nothing to review.
- Then use `AskUserQuestion` exactly once with two options, putting the recommended option first and suffixing its label with `(Recommended)`:
Expand Down
Loading