Skip to content

Conversation

@rka-oai
Copy link

@rka-oai rka-oai commented Nov 11, 2025

Summary

  • allow the resume picker to persist pinned sessions and highlight them with a star column
  • expose a Shift+S shortcut to toggle the pin state, update hints, and keep pinned rows sorted before others
  • refresh the resume picker snapshot and add tests to cover the new behaviors

Testing

  • cargo test -p codex-tui
  • Worked locally when I did cargo run -p codex-cli --bin codex resume and used shift+s.
Screenshot 2025-11-10 at 5 31 40 PM

Codex Task

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@rka-oai
Copy link
Author

rka-oai commented Nov 11, 2025

@codex fix the lint here.

help: use std::io::Error::other
|
324 - .map_err(|err| std::io::Error::new(ErrorKind::Other, err))?;
324 + .map_err(|err| std::io::Error::other(err))?;
|

error: use of a disallowed method ratatui::style::Stylize::yellow
--> tui/src/resume_picker.rs:897:18
|
897 | "★ ".yellow()
| ^^^^^^
|
= note: Avoid yellow; prefer other colors in tui/styles.md.
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods
note: the lint level is defined here
--> tui/src/lib.rs:5:9
|
5 | #![deny(clippy::disallowed_methods)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: use of a disallowed method ratatui::style::Stylize::yellow
--> tui/src/resume_picker.rs:939:33
|
939 | Span::from(preview).yellow()
| ^^^^^^
|
= note: Avoid yellow; prefer other colors in tui/styles.md.
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods

error: could not compile codex-tui (lib) due to 3 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

That's the error log for lint. I believe the command to run this lint is like: cargo clippy --target aarch64-apple-darwin --all-features --tests --profile dev -- -D warnings

Or something like that.

@etraut-openai etraut-openai added the oai-pr PRs posted by Codex team members label Nov 11, 2025
@chatgpt-codex-connector
Copy link
Contributor

Summary

  • Replaced the manual ErrorKind::Other wrapping with std::io::Error::other when saving pinned conversations so the serialization path satisfies Clippy’s lint. codex-rs/tui/src/resume_picker.rsL315-L325
  • Restyled the pinned indicator star and preview highlight with cyan, keeping the visual emphasis on pinned rows while complying with the TUI style guide’s disallowed yellow rule. codex-rs/tui/src/resume_picker.rsL887-L942

Testing

  • just fix -p codex-tui
  • cargo test -p codex-tui

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex oai-pr PRs posted by Codex team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants