[App-server] add new v2 events:item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
#6559
+127
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
changed the title
item/reasoning/delta and item/agentMessage/delta
celia-oai
changed the title
item/reasoning/delta and item/agentMessage/deltaitem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
celia-oai
changed the title
item/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAddeditem/reasoning/delta, item/agentMessage/delta & item/reasoning/summaryPartAdded
owenlin0
reviewed
Nov 13, 2025
| // The logic of whether to emit reasoning summary or reasoning raw content delta is handled in the core. | ||
| // The client just receives ReasoningDelta notifications and handles both cases the same way. | ||
| EventMsg::ReasoningContentDelta(ReasoningContentDeltaEvent { item_id, delta, .. }) | ||
| | EventMsg::ReasoningRawContentDelta(ReasoningRawContentDeltaEvent { |
Contributor
There was a problem hiding this comment.
ooc what's the difference between Content and RawContent?
| #[ts(export_to = "v2/")] | ||
| pub struct ReasoningSummaryPartAddedNotification { | ||
| pub item_id: String, | ||
| } |
Contributor
There was a problem hiding this comment.
The Reasoning item is currently defined as:
Reasoning {
id: String,
text: String,
},
should text become something like content_parts: Vec<String>?
Contributor
There was a problem hiding this comment.
this notification doesn't make a whole lot of sense without it IMO
| #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, JsonSchema, TS)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[ts(export_to = "v2/")] | ||
| pub struct ReasoningDeltaNotification { |
Contributor
There was a problem hiding this comment.
Does Responses API associate the delta with a specific content part index?
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
7 times, most recently
from
c6f688c to
f036f25
Compare
celia-oai
force-pushed
the
dev/cc/add-item-2
branch
from
f036f25 to
0a43e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core event to app server event mapping:
codex/event/reasoning_content_delta&codex/event/reasoning_raw_content_delta->item/reasoning/deltacodex/event/agent_message_content_delta→item/agentMessage/delta.codex/event/agent_reasoning_section_break->item/reasoning/summaryPartAdded(added a small change in core to pass downitem_id).Tested with the
git checkout owen/app_server_test_client && cargo run -p codex-app-server-test-client -- send-message-v2 "hello"and verified that new events are emitted correctly.