[codex-rs] fix: exit code 1 if no api key #697
Merged
+31
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oai-ragona
reviewed
Apr 27, 2025
codex-rs/exec/src/lib.rs
Outdated
Comment on lines
59
to
61
| "\n\x1b[31mMissing OpenAI API key.\x1b[0m\n\n\ | ||
| Set the environment variable \x1b[1mOPENAI_API_KEY\x1b[0m and re-run this command.\n\ | ||
| You can create a key here: \x1b[1m\x1b[4mhttps://platform.openai.com/account/api-keys\x1b[0m\n" |
There was a problem hiding this comment.
Nitpick; we have owo-colors in the workspace already, this would read better if we stylized with that instead. See: https://docs.rs/owo-colors/latest/owo_colors/
There was a problem hiding this comment.
I have good news for you: #719
|
|
bolinfest
reviewed
Apr 29, 2025
| @@ -24,3 +24,4 @@ tokio = { version = "1", features = [ | |||
| ] } | |||
| tracing = { version = "0.1.41", features = ["log"] } | |||
| tracing-subscriber = { version = "0.3.19", features = ["env-filter"] } | |||
| owo-colors = "4.2.0" | |||
bolinfest
reviewed
Apr 29, 2025
| @@ -39,6 +51,20 @@ pub async fn run_main(cli: Cli) -> anyhow::Result<()> { | |||
| .. | |||
| } = cli; | |||
|
|
|||
| // --------------------------------------------------------------------- | |||
There was a problem hiding this comment.
This header comment doesn't fit with the existing style.
|
I'm moving this around a bit in #719 FYI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.