Skip to content

test: synchronize replacement WebSocket handshake #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstuart-oai merged 1 commit into from
Sep 18, 2026
+6 −1
Merged

test: synchronize replacement WebSocket handshake #3891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/lib/responses/test_websocket_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ async def test_sync_close_during_replacement_handshake(monkeypatch: pytest.Monke
opening = threading.Event()
release_open = threading.Event()
closing = threading.Event()
replacement_accepted = threading.Event()

def reconnect(_event: ReconnectingEvent) -> ReconnectingOverrides:
return {"extra_headers": {"X-Recovery": "fresh"}}
Expand All @@ -589,6 +590,8 @@ def script(socket: ServerConnection) -> None:
if socket.request.headers.get("X-Recovery") != "fresh":
assert disconnect.wait(5)
socket.close(code=1011)
else:
replacement_accepted.set()

with script_server(script, expected_connections=2) as url:
async with session_for(
Expand All @@ -603,7 +606,9 @@ def script(socket: ServerConnection) -> None:
def delayed_open(query: Any, headers: Any) -> Any:
opening.set()
assert release_open.wait(5)
return make_ws(query, headers)
socket = make_ws(query, headers)
assert replacement_accepted.wait(5)
return socket

def observed_close() -> None:
try:
Expand Down
Loading